Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups2 #662

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Groups2 #662

merged 8 commits into from
Aug 14, 2023

Conversation

Paul-Ferrell
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

Copy link
Collaborator

@francinelapid francinelapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue where I tried to use pav group remove 15 s1 to remove test 15 and series 1 but it was unable to remove test 15

 $ pav group remove test2 15 s1
There were one or more errors when removing tests.
Given test '15' to remove, but it is not in group 'test2'.
Removed 1 item.

@francinelapid francinelapid self-requested a review August 8, 2023 15:31
@Paul-Ferrell Paul-Ferrell merged commit 1e258c7 into master Aug 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants