Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added warning for 'series:' instead of 'test_sets:' in series file. #672

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Added warning for 'series:' instead of 'test_sets:' in series file. #672

merged 3 commits into from
Aug 9, 2023

Conversation

Paul-Ferrell
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@francinelapid francinelapid linked an issue Aug 2, 2023 that may be closed by this pull request
pav series run not working for v2.4 #580
Closed
@francinelapid
Copy link
Collaborator

Code looks good to me. I will test before I approve

francinelapid
francinelapid previously approved these changes Aug 2, 2023
View reviewed changes
@Paul-Ferrell
Copy link
Collaborator Author

This worked for the user. If everything looks good to you it can be merged as soon as the tests pass.

francinelapid
francinelapid approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@francinelapid francinelapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes since my last review look fine.

@Paul-Ferrell Paul-Ferrell merged commit 4bd52e9 into master Aug 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelapid francinelapid francinelapid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pav series run not working for v2.4
2 participants
@Paul-Ferrell @francinelapid