New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paul's fix #675

Closed

jennfshr wants to merge 1 commit into hpc:master from jennfshr:fix_resolver_request

Collaborator

jennfshr commented Aug 8, 2023

Code review checklist:

Code is generally sensical and well commented
Variable/function names all telegraph their purpose and contents
Functions/classes have useful doc strings
Function arguments are typed
Added/modified unit tests to cover changes.
New features have documentation added to the docs.
New features and backwards compatibility breaks are noted in the RELEASE.md


          paul's fix

7978d03

Collaborator

Paul-Ferrell commented Aug 8, 2023

Superceded by #676

Paul-Ferrell closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet