New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed flux import. #677

Merged

Paul-Ferrell merged 3 commits into master from flux-import-fix

Aug 14, 2023

Collaborator

Paul-Ferrell commented Aug 9, 2023

Code review checklist:

Code is generally sensical and well commented
Variable/function names all telegraph their purpose and contents
Functions/classes have useful doc strings
Function arguments are typed
Added/modified unit tests to cover changes.
New features have documentation added to the docs.
New features and backwards compatibility breaks are noted in the RELEASE.md


          Fixed flux import.

48b85f7

Paul-Ferrell requested a review from nicholas-sly

August 9, 2023 21:15

nicholas-sly previously approved these changes

View reviewed changes

Collaborator

nicholas-sly left a comment

Looks good. Worked on our flux system.


          Fixed style issue.

78a9a0b

Paul-Ferrell dismissed nicholas-sly’s stale review via

78a9a0b

August 9, 2023 21:28


          Merge branch 'master' into flux-import-fix

b17a1e6

Paul-Ferrell merged commit 44745cb into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet