HPCC-33163 Avoid wasteful invalid Span log entries

- Adds ISpan isValid method - Avoids wasteful log outpus if span !isValid Signed-off-by: Rodrigo Pastrana <[email protected]>
hpcc-systems · Jan 22, 2025 · fa042bf · fa042bf
1 parent 045afbd
commit fa042bf
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/system/jlib/jlog.hpp b/system/jlib/jlog.hpp
@@ -608,7 +608,7 @@ class jlib_decl LogMsgTraceInfo
 
     const char * queryTraceID() const
     {
-        if (span)
+        if (span && span->isValid())
         {
             const char * traceId = span->queryTraceId();
             if (traceId)
@@ -619,7 +619,7 @@ class jlib_decl LogMsgTraceInfo
 
     const char * querySpanID() const
     {
-        if (span)
+        if (span && span->isValid())
         {
             const char * spanId = span->querySpanId();
             if (spanId)

diff --git a/system/jlib/jtrace.cpp b/system/jlib/jtrace.cpp
@@ -757,6 +757,15 @@ class CSpan : public CInterfaceOf<ISpan>
         return span ? span->IsRecording() : false;
     }
 
+    virtual bool isValid() const override
+    {
+        if (span == nullptr)
+            return false;
+
+        auto spanCtx = span->GetContext();
+        return spanCtx.IsValid();
+    }
+
     virtual void setSpanStatusSuccess(bool spanSucceeded, const char * statusMessage)
     {
         if (span != nullptr)
@@ -910,6 +919,7 @@ class CNullSpan final : public CInterfaceOf<ISpan>
     virtual void toString(StringBuffer & out) const override {}
     virtual void getLogPrefix(StringBuffer & out) const override {}
     virtual bool isRecording() const { return false; }
+    virtual bool isValid() const { return false; }
 
     virtual void recordException(IException * e, bool spanFailed, bool escapedScope) override {}
     virtual void recordError(const SpanError & error) override {};

diff --git a/system/jlib/jtrace.hpp b/system/jlib/jtrace.hpp
@@ -133,6 +133,7 @@ struct SpanTimeStamp
 
 interface ISpan : extends IInterface
 {
+    virtual bool isValid() const = 0;
     virtual void setSpanAttribute(const char * key, const char * val) = 0;
     virtual void setSpanAttribute(const char *name, __uint64 value) = 0;
     virtual void setSpanAttributes(const IProperties * attributes) = 0;