Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32168 Add Dynamic ECL-Bundles Listing Feature for Bundle Testing… #18822

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Charan-Sharan
Copy link
Contributor

@Charan-Sharan Charan-Sharan commented Jun 27, 2024

Add Dynamic ECL-Bundles Listing Feature for Bundle Testing Action File.
This code adds a dynamic feature to list the ecl-bundles list from the hpcc-systems/ecl-bundles repository. Adding this feature removes the need to manually updated the bundles list when a new bundle is added.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32168

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR
Assigning user:

@AttilaVamos AttilaVamos self-requested a review July 10, 2024 12:08
@Charan-Sharan Charan-Sharan marked this pull request as ready for review July 10, 2024 16:37
Copy link
Contributor

@AttilaVamos AttilaVamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but there are 2 questions.

- name: Scrap Bundles List
shell: "bash"
run: |
TABLES_DATA=$( cat README.rst | grep -oE -e "\|[^\|]*\|" -e "==.*==" | sed 's/|//g' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if no README.rst?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add condition to check if README.rst file is present. So that it won't fail the workflow file for not having a README.rst file.

break
fi
done
BUNDLES_TO_TEST=$(echo $BUNDLES_TO_TEST | sed 's/ /\n/g' | sort -bf | uniq -i )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sort command already has a -u or --unique parameter. Is that suitable here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Yes, the sort command has a -u parameter, it would be suitable here and we can eliminate uniq command.

Copy link
Contributor

@Michael-Gardner Michael-Gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your way works, and you're happy with it, that's fine. I added a different way to write out a block of code. I personally think it's a bit cleaner. You will see the cat redirect EOF style used in a lot of bash code

.github/workflows/bundleTest-thor.yml Outdated Show resolved Hide resolved
@Michael-Gardner Michael-Gardner self-requested a review July 15, 2024 17:08
Copy link
Contributor

@AttilaVamos AttilaVamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@Charan-Sharan
Copy link
Contributor Author

@ghalliday could you please merge this PR?

@ghalliday ghalliday merged commit c00ed43 into hpcc-systems:master Jul 25, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants