-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32168 Add Dynamic ECL-Bundles Listing Feature for Bundle Testing… #18822
HPCC-32168 Add Dynamic ECL-Bundles Listing Feature for Bundle Testing… #18822
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32168 Jirabot Action Result: |
df87824
to
f71606f
Compare
253d06b
to
bca87c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, but there are 2 questions.
- name: Scrap Bundles List | ||
shell: "bash" | ||
run: | | ||
TABLES_DATA=$( cat README.rst | grep -oE -e "\|[^\|]*\|" -e "==.*==" | sed 's/|//g' ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if no README.rst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add condition to check if README.rst file is present. So that it won't fail the workflow file for not having a README.rst file.
break | ||
fi | ||
done | ||
BUNDLES_TO_TEST=$(echo $BUNDLES_TO_TEST | sed 's/ /\n/g' | sort -bf | uniq -i ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sort command already has a -u or --unique parameter. Is that suitable here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Yes, the sort command has a -u parameter, it would be suitable here and we can eliminate uniq command.
bca87c3
to
d731ea7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your way works, and you're happy with it, that's fine. I added a different way to write out a block of code. I personally think it's a bit cleaner. You will see the cat redirect EOF
style used in a lot of bash code
d731ea7
to
2976c93
Compare
2976c93
to
f84d819
Compare
… Action File Signed-off-by: Charan-Sharan <[email protected]>
f84d819
to
6c72bb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
@ghalliday could you please merge this PR? |
Add Dynamic ECL-Bundles Listing Feature for Bundle Testing Action File.
This code adds a dynamic feature to list the ecl-bundles list from the hpcc-systems/ecl-bundles repository. Adding this feature removes the need to manually updated the bundles list when a new bundle is added.
Type of change:
Checklist:
Smoketest:
Testing: