Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32901 Make super file cost and reads/write updates consistent #19457

Open
wants to merge 1 commit into
base: candidate-9.10.x
Choose a base branch
from
Open

HPCC-32901 Make super file cost and reads/write updates consistent #19457

wants to merge 1 commit into from

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Jan 27, 2025 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@shamser shamser force-pushed the issue32901 branch 3 times, most recently from c0cafb7 to e18c024 Compare January 27, 2025 13:39
@shamser shamser changed the title WIP HPCC-32901 Super file cost and reads/write updates are inconsistent Jan 27, 2025
@shamser shamser marked this pull request as ready for review January 27, 2025 13:40
@shamser
HPCC-32901 Make super file cost and reads/write updates consistent
c139c79 
- Super file's numDiskReads, numDiskWrites, readCost and writeCost
stats are re-calculated from subfiles stats every time a subfile
is added or removed from a super file
- Super file's readCost and numReads are updated every time the
superfile is read

Signed-off-by: Shamser Ahmed <[email protected]>
@shamser shamser requested a review from jakesmith January 28, 2025 10:15
@shamser shamser changed the title HPCC-32901 Super file cost and reads/write updates are inconsistent HPCC-32901 Make super file cost and reads/write updates consistent Jan 28, 2025
@jakesmith
Copy link
Member

@AttilaVamos - do you know what is causing the test-bundles-on-thor action to fail?
I see it has found 2 cores, and there are 2 trace files, but the stacks are corrupt and/or appear unaligned.
Should there be associated thor log files related to this failure too?
Is this reproducible outside of github actions?

@AttilaVamos
Copy link
Contributor

@jakesmith
There is a PR-19438 to fix missing symbols from stack-trace.
I know the core generation in Bundle tests happened at the end of test, in the clean-up phase, but it seems it is GH Action environment related. A kind of problem with Tensorflow and Python 3.10.
In OBT I can't see same problem with bundle tests, but it using Python 3.6.8.

@jakesmith
Copy link
Member

@jakesmith There is a PR-19438 to fix missing symbols from stack-trace. I know the core generation in Bundle tests happened at the end of test, in the clean-up phase, but it seems it is GH Action environment related. A kind of problem with Tensorflow and Python 3.10. In OBT I can't see same problem with bundle tests, but it using Python 3.6.8.

ok, will be interesting to see what the stack trace is on subsequent PRs after PR-19438 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith Awaiting requested review from jakesmith

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamser @jakesmith @AttilaVamos