Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-33341 Improve rowservice security messages #19473

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Feb 3, 2025

Add some context (file group and keyPairName) to dafilesrv row service security exceptions.
This should help users/ops. to diagnose what is usually a configuration issue.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Add some context (file group and keyPairName) to dafilesrv row
service security exceptions.
This should help users/ops. to diagnose what is usually a
configuration issue.

Signed-off-by: Jake Smith <[email protected]>
Copy link

github-actions bot commented Feb 3, 2025

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33341

Jirabot Action Result:
Assigning user: [email protected]
Workflow Transition To: Merge Pending
Updated PR

@jakesmith jakesmith requested a review from mckellyln February 3, 2025 19:19
@jakesmith
Copy link
Member Author

@AttilaVamos - any idea what the unittest failure is (I'm sure it's not related to this PR) and/or why there is no artifacts collected?

@jakesmith
Copy link
Member Author

FWIW - I tested this PR based off 9.8.x to see if it was a 9.6.x issue only, and it did not fail there: #19474

NB: I also reran this PR and the unittests failure reoccured.

Copy link
Contributor

@mckellyln mckellyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Approved.

@@ -30,7 +30,8 @@
#define DAFSCLIENT_API DECL_IMPORT
#endif

#define DAFILESRV_METAINFOVERSION 2
// NB: this is the version of the metainfo structure created by the WsDfu service and sent by a dafilesrv client
#define DAFILESRV_METAINFOVERSION 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the version used anywhere ?

@jakesmith jakesmith merged commit b832b50 into hpcc-systems:candidate-9.6.x Feb 6, 2025
52 of 54 checks passed
Copy link

github-actions bot commented Feb 6, 2025

Jirabot Action Result:
Added fix version: 9.6.82
Added fix version: 9.8.58
Added fix version: 9.10.4
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants