Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth rework #953

Merged
merged 123 commits into from
Dec 17, 2024
Merged

Auth rework #953

merged 123 commits into from
Dec 17, 2024

Conversation

FancMa01
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Vulnerability fix (package bumps or CodeQL adjustments to ensure code security)
  • This change requires a documentation update

Developer Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved any conflicts with the branch I am attempting to merge to.
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have ensured that my code does not unecessarily duplicate existing cod
  • I have ensured that all security checks have been passed
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state

Reviewer Checklist

  • I have pulled the branch into my local environemtn and started the project succesfully
  • I have reviewed the code for proper comments and mispellings
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state
  • Submitting any relevant Forms relays proper messaging to user
  • I have checked that all security checks have been passed
  • I have checked that all backend routes have proper validation

ydahal1 and others added 30 commits September 16, 2024 16:51
* Remove existing manual login/logout code for fresh start

* save progress

* introduce new login

introduce login/register, basic layout component.

Able to be accessed by /login and /register respectively.

Will need to rework login and load order and such later

* Max characters applied

* update look and feel

* Further css adjustments

* give new-password so autocomplete doesn't happen

* added autoComplete off in login page aswell

---------

Co-authored-by: yadhap Dahal <[email protected]>
…tiy functions. Modified RoleTypes, UserRoles model, added migration file and model for refresh_token
Added registration and login routes, middlewares, controlles and util…
* Remove existing manual login/logout code for fresh start

* save progress

* introduce new login

introduce login/register, basic layout component.

Able to be accessed by /login and /register respectively.

Will need to rework login and load order and such later

* Max characters applied

* update look and feel

* Further css adjustments

* give new-password so autocomplete doesn't happen

* added autoComplete off in login page aswell

* add forgot password, password complexity validator, reset password

---------

Co-authored-by: yadhap Dahal <[email protected]>
* Remove existing manual login/logout code for fresh start

* save progress

* introduce new login

introduce login/register, basic layout component.

Able to be accessed by /login and /register respectively.

Will need to rework login and load order and such later

* Max characters applied

* update look and feel

* Further css adjustments

* give new-password so autocomplete doesn't happen

* added autoComplete off in login page aswell

* add forgot password, password complexity validator, reset password

* remove i18n and language switcher

* adjust footer

* add comment

* home css and structure adjustments

* rename css class

---------

Co-authored-by: yadhap Dahal <[email protected]>
…ock data with a dedicated test database for more accurate unit tests. Implemented end-to-end route tests for authentication and user routes.
Refactored testing environment to mirror production setup.
* create my account page

* Adjust look and feel

Change password replaces logout in top left, one form for displaying and editing information.
* create my account page

* Initial Framework

Still need to add Modals and functionality, but waiting on wiring basic flow first so we can have real data to test with.

* save
additional auth routes and session mgmt routes
FancMa01 and others added 15 commits October 25, 2024 14:49
…gistered-user

Yadhap/verify email self registered user
* bug fixes for application creation/deletion/switching for left nav and application screens

* remove console logs

* remove unused functions from application screen

* Save Progress

* fixes

* Update Backend.js

* Fix Header for stability

* save progress

* Update to control reader disabled

* Update to allow user to logout no matter what

* Allow user to update their own account and create allowed resource list

* Handle login invalid values

* 403 fallback page

* save

* fix spelling error

* fix spelling

* Patch to not show owner/admin no route access and also fix authController to return user roles and applications on verify email login

* Add more conditionals
* Model and Migration

* Routes, Controllers, Middleware for instance settings
* bug fixes for application creation/deletion/switching for left nav and application screens

* remove console logs

* remove unused functions from application screen

* Save Progress

* fixes

* Update Backend.js

* Fix Header for stability

* save progress

* Update to control reader disabled

* Update to allow user to logout no matter what

* Allow user to update their own account and create allowed resource list

* Handle login invalid values

* 403 fallback page

* save

* save

* Model and Migration

* Routes, Controllers, Middleware for instance settings

* save

* save progresss

* save

* finish

* Update error message

* Changed Steps on Start up Wizard to horizontal

---------

Co-authored-by: yadhap Dahal <[email protected]>
* bug fixes for application creation/deletion/switching for left nav and application screens

* remove console logs

* remove unused functions from application screen

* Save Progress

* fixes

* Update Backend.js

* Fix Header for stability

* save progress

* Update to control reader disabled

* Update to allow user to logout no matter what

* Allow user to update their own account and create allowed resource list

* Handle login invalid values

* 403 fallback page

* save

* save

* Model and Migration

* Routes, Controllers, Middleware for instance settings

* save

* save progresss

* save

* finish

* request access route

* Only Owners or Admins should see tours

* Finish notification

* remove extra  /
…es in front end so the front end gets right kind of code from Azure before sending to backend
Added login/register with azure option in the back end and made chang…
* Oauth2 front end

* wire front and backend azure login

* Show/hide traditional

* small bug fix to prevent multiple logins from being fired

* Fixed login loop that occured when MS login failed. Also fixed issue where the roles and applications for newly created azure user was coming back undefined

---------

Co-authored-by: yadhap Dahal <[email protected]>
* Remove unused packages

* Bug Fixes for left nav, constraints, and consumers
* Remove unused packages

* Bug Fixes for left nav, constraints, and consumers

* updates

* Users Page and various docs updates

* adjustments
* Fix user registration to not show success unless error message is shown and remove duplicate create basic user route

* Set width of all components to 40rem for login for consistency

* hide change password method for microsoft accounts
* centralize getting and setting user functions

* Small Patch to Login

Fixes Logging in when user attempts to log in with basic auth when they are registered to an Azure Account
FancMa01 and others added 3 commits December 3, 2024 09:34
* centralize getting and setting user functions

* Small Patch to Login

Fixes Logging in when user attempts to log in with basic auth when they are registered to an Azure Account

* Finalize cookie transition for tokens

Move to http cookies rather than storing access token in local storage.

* Centralize token setting to a function

Centralize repeated code to one location for ease of managing

* remove unused code
* centralize getting and setting user functions

* Small Patch to Login

Fixes Logging in when user attempts to log in with basic auth when they are registered to an Azure Account

* Finalize cookie transition for tokens

Move to http cookies rather than storing access token in local storage.

* Centralize token setting to a function

Centralize repeated code to one location for ease of managing

* remove unused code
Tombolo/server/server.js Dismissed Show dismissed Hide dismissed
FancMa01 and others added 7 commits December 10, 2024 16:57
* centralize getting and setting user functions

* Small Patch to Login

Fixes Logging in when user attempts to log in with basic auth when they are registered to an Azure Account

* Finalize cookie transition for tokens

Move to http cookies rather than storing access token in local storage.

* Centralize token setting to a function

Centralize repeated code to one location for ease of managing

* remove unused code

* save progress

* save

* Naive Double Cookie CSRF Protection Finished

* Update middleware to reflect production env variable code

* Add in prod vs dev code

* Make csrf cookie only valid for 15 minutes
* finish double signed CSRF implementation

* remove local storage necessity
this.props code was leftover despite the rework into a functional component. Repaired the errors form this
@FancMa01 FancMa01 merged commit d82a0ed into dev Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants