Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The expected start and completion time were cleared when the componen… #957

Conversation

ydahal1
Copy link
Collaborator

@ydahal1 ydahal1 commented Nov 25, 2024

Description

Fixed issue with clearing expected start and completion times during component load. This is not intended behavior during JM update. Previously, these fields were cleared even if the user did not intend to update them, forcing re-entry. Now, these fields are only cleared when the user modifies the run window values.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Vulnerability fix (package bumps or CodeQL adjustments to ensure code security)
  • This change requires a documentation update

Developer Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved any conflicts with the branch I am attempting to merge to.
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have ensured that my code does not unecessarily duplicate existing cod
  • I have ensured that all security checks have been passed
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state

Reviewer Checklist

  • I have pulled the branch into my local environemtn and started the project succesfully
  • I have reviewed the code for proper comments and mispellings
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state
  • Submitting any relevant Forms relays proper messaging to user
  • I have checked that all security checks have been passed
  • I have checked that all backend routes have proper validation

…t load. This was causing issue while a user tries to update a JM. User might not want to edit the expected end and start time, but these fields are cleared forcing user to re-enter these values. The new changes will only clear those 2 fields if a user touched the run window values
…nent loading. This ensures the expected start and end time input fields are properly updated. The change simplifies the codebase without altering functionality
Copy link
Collaborator

@FancMa01 FancMa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@FancMa01 FancMa01 merged commit ee1a57c into dev Nov 26, 2024
2 checks passed
@ydahal1 ydahal1 deleted the yadhap/clear-expectedstart-and-expected-complete-on-run-window-change branch December 3, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants