Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Indicators (Warning labels) in the left navigation bar and als… #971

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ydahal1
Copy link
Collaborator

@ydahal1 ydahal1 commented Dec 9, 2024

Description

This PR improves communication of cluster reachability issues by adding warning labels to the left navigation bar and the clusters table. A new "Test Connectivity" button allows users to check the current status of cluster connectivity. The clusters table now includes the last reachability status and, when hovered, displays details such as the last reached date and time, last monitored date and time, and error messages from the cluster, depending on whether the cluster is reachable or not

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Vulnerability fix (package bumps or CodeQL adjustments to ensure code security)
  • This change requires a documentation update

Developer Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved any conflicts with the branch I am attempting to merge to.
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have ensured that my code does not unecessarily duplicate existing cod
  • I have ensured that all security checks have been passed
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state

Reviewer Checklist

  • I have pulled the branch into my local environemtn and started the project succesfully
  • I have reviewed the code for proper comments and mispellings
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state
  • Submitting any relevant Forms relays proper messaging to user
  • I have checked that all security checks have been passed
  • I have checked that all backend routes have proper validation

… in clusters table to communicate cluster reachability issues with the users. Added button to test connectivity and display current reachability information in the table along with last reachable date time and also error message from cluster if the cluster is currently unreachable
Copy link
Collaborator

@FancMa01 FancMa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we optional chaining when checking if reachable is false on line 35. The way it is currently written, if reachabilityInfo is there but reachable is not it will throw an error.

@FancMa01 FancMa01 merged commit 6787bb8 into dev Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants