IDE-1050 Upgrade GH Action to match HPCC-Platform pattern #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghalliday
reviewed
Dec 13, 2023
There was a problem hiding this comment.
@GordonSmith please can you provide more information about what this change is doing. The jira doesn't contain much information about what it is achieving. There is also a big chunk of code moved which is hard to isolate what changed within it.
The commit message should also be understandable in a change log without any context.
Move vcpkg_overlays into vcpkg repository (similar to HPCC-Platform) Signed-off-by: Gordon Smith <[email protected]>
GordonSmith
force-pushed
the
IDE-1050-GH_ACTIONS
branch
from
8472459
to
6b4740e
Compare
GordonSmith
changed the title
FWIW the code wasn't changed as such, it was replaced with the HPCC-Platform code. |
ghalliday
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.