Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dependencies needed to install pyodbc #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added dependencies needed to install pyodbc #12

wants to merge 1 commit into from

Conversation

dlfryar-zz
Copy link

pyodbc is needed by the Monasca Agent Vertica plugin

Added a Vertica Database plugin
https://review.openstack.org/#/c/195413/10

pyodbc is needed by the Monasca Agent Vertica plugin

Added a Vertica Database plugin
https://review.openstack.org/#/c/195413/10
@dlfryar-zz
Copy link
Author

I considered putting them in the Agent, however, our ansible-vertica role is specific to Monasca. If these were part of the ansible-monasca-agent and you were not running Vertica then you would get PIP/APT dependencies and config files that may or may not be applicable/needed. Our ansible-percona does something similar with the config file. Perhaps we need some duplication in ansible-monasca-agent - not sure.

node_dependencies.yml puts the PIP deps in the Monasca venv

  • name: Install Vertica PIP dependencies
    pip: name=pyodbc state=present virtualenv="{{monasca_virtualenv_dir}}"
    when: not skip_install

@tkuhlman
Copy link
Contributor

tkuhlman commented Jul 9, 2015

This doesn't seem the right place for this config. You are adding dependencies for a Vertica client, this role sets up the Vertica server. In many cases the client and server are not the same machine so I think the ability to install them independently is needed.

@dlfryar-zz
Copy link
Author

Comparing it to the MySQL plugin which should have an equivalent argument, I didn't find it to be implemented that way. In the MySQL case the deps come from ansible-percona or monasca-vagrant.

http://postimg.org/image/9mci6dmof/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants