-
Notifications
You must be signed in to change notification settings - Fork 7
Refactor market simulation to be more readable and set the start conf… #10
Conversation
…iguration to be computable in less than 1 minute.
Have you tested the whole pipeline? I wont be able to test it until next week. But I would trust you and merge when you say you tested the whole pipeline. ;) |
Except for a small error in the monte_carlo file, everything seems to work as expected and the graphs don't seem abnormal. |
Then please change demand_learning to use the scenario that we are currently creating as the default. Which bug do you mean? |
I already use the current scenario as default but in demand_learning we compare the two scenarios at the end. Shall I comment it out for the moment? The problem was that I didn't remove all unnecessary output, which was only used when Rainer still calculated the logit in the notebook. I will commit the changed notebook at the end of today. |
I see your point. Let’s ignore that issue for now, as I think it’s clear that users have to generate both conpare scenarios. I’ll review after your fix. |
fixed |
monte_carlo.ipynb
Outdated
@@ -174,7 +174,7 @@ | |||
}, | |||
{ | |||
"cell_type": "code", | |||
"execution_count": null, | |||
"execution_count": 35, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please commit a cleared or ran-once notebook and I’ll merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…iguration to be computable in less than 1 minute.