Skip to content
This repository has been archived by the owner on Aug 24, 2020. It is now read-only.

Refactor market simulation to be more readable and set the start conf… #10

Merged
merged 3 commits into from
Mar 24, 2018

Conversation

tomschw
Copy link
Collaborator

@tomschw tomschw commented Mar 22, 2018

…iguration to be computable in less than 1 minute.

…iguration to be computable in less than 1 minute.
@tomschw tomschw requested a review from Bouncner March 22, 2018 10:58
@Bouncner
Copy link
Contributor

Have you tested the whole pipeline?

I wont be able to test it until next week. But I would trust you and merge when you say you tested the whole pipeline. ;)

@tomschw
Copy link
Collaborator Author

tomschw commented Mar 22, 2018

Except for a small error in the monte_carlo file, everything seems to work as expected and the graphs don't seem abnormal.
One current problem is, that the demand_learning notebook wants to load the S1 notebooks, which currently aren't getting created. If we keep it like that, it would probably be wise to simply run all notebooks with every strategy, simply so we can expect them. I found an easy way to do, which can be found in issue #8 .

@Bouncner
Copy link
Contributor

Then please change demand_learning to use the scenario that we are currently creating as the default.

Which bug do you mean?

@tomschw
Copy link
Collaborator Author

tomschw commented Mar 23, 2018

I already use the current scenario as default but in demand_learning we compare the two scenarios at the end. Shall I comment it out for the moment?

The problem was that I didn't remove all unnecessary output, which was only used when Rainer still calculated the logit in the notebook. I will commit the changed notebook at the end of today.

@Bouncner
Copy link
Contributor

I see your point.

Let’s ignore that issue for now, as I think it’s clear that users have to generate both conpare scenarios.

I’ll review after your fix.

@tomschw
Copy link
Collaborator Author

tomschw commented Mar 23, 2018

fixed

@@ -174,7 +174,7 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 35,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit a cleared or ran-once notebook and I’ll merge.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Bouncner Bouncner merged commit beb4d30 into master Mar 24, 2018
@Bouncner Bouncner deleted the refactor_market_simulation branch March 24, 2018 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants