Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

508 allow users to show most liked pictures #512

Merged
merged 38 commits into from
May 26, 2023
Merged

508 allow users to show most liked pictures #512

merged 38 commits into from
May 26, 2023

Conversation

LinoH5
Copy link
Collaborator

@LinoH5 LinoH5 commented May 17, 2023

  • Erlaubt es Nutzern auf der Start-, Stöbern- und den Archivseiten zu entscheiden, ob er die Neuzugänge/Unsere Bilder sehen wollen, oder aber die Bestbewerteten Bilder (meiste Likes):
    most-liked-staging
    new-staging

  • Die Show-More-Seite, welche über Mehr Anzeigen zu erreichen ist zeigt dann auch entsprechend die Neuzugänge/Unsere Bilder, oder aber die Bestbewerteten Bilder:
    most-liked-show-more

LinoH5 and others added 21 commits May 16, 2023 00:46
@LinoH5
start implementing tab based overview content selection
9ea3a87
@LinoH5
allow custom width for tag and picture overview
e110097
@LinoH5
adjust tag preview min width to fit to mobile screen
1c0efae
@LinoH5
minor changes to css
1a2a03f
@LinoH5
Merge remote-tracking branch 'origin/staging' into 501-custom-overvie…
b9f220a 
…w-inhaltsauswahl
@LinoH5
Merge remote-tracking branch 'origin/staging' into 501-custom-overvie…
5516114 
…w-inhaltsauswahl
@LinoH5
start fixing tests
c81b162
@LinoH5
add option to show most liked pictures instead of neuzugänge/unsere b…
be7dd07 
…ilder
@LinoH5
Merge branch 'staging' into 501-custom-overview-inhaltsauswahl
a750830
@LinoH5
add tooltips for tabs
6db9f5d
@LinoH5
show scroll buttons on mobile
6df6dae
@LinoH5
dont use Children anymore
c1d5ca1
@LinoH5
remove unneccessary const
99ad2fc
@LinoH5
Merge remote-tracking branch 'origin/501-custom-overview-inhaltsauswa…
ba81fb5 
…hl' into 508-allow-users-to-show-most-liked-pictures
@LinoH5
adjust to changes made to OverviewContainer
7ba9db5
@LinoH5
correct sorting order for most liked, make it work for staging
876d22b
@LinoH5
support to set default option
dcc8121
@LinoH5
Merge remote-tracking branch 'origin/501-custom-overview-inhaltsauswa…
f373898 
…hl' into 508-allow-users-to-show-most-liked-pictures
@LinoH5
make default option optional
2947b5a
@LinoH5
Merge remote-tracking branch 'origin/501-custom-overview-inhaltsauswa…
af21e2c 
…hl' into 508-allow-users-to-show-most-liked-pictures
@LinoH5
show most liked as default option on start page
085d30d
@LinoH5 LinoH5 linked an issue May 17, 2023 that may be closed by this pull request
Allow users to show most liked pictures #508
Closed
1 task
@LinoH5 LinoH5 marked this pull request as draft May 17, 2023 13:49
@LinoH5 LinoH5 marked this pull request as ready for review May 23, 2023 11:26
olschulz
olschulz requested changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@olschulz olschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe look for a slightly different color for the OverviewContainer. Also are all of the fetchPolicies still necessary now that we have changed the mergeByRef method?

projects/bp-gallery/src/components/common/PictureOverview.tsx Outdated Show resolved Hide resolved
projects/bp-gallery/src/components/common/TagOverview.tsx Outdated Show resolved Hide resolved
projects/bp-gallery/src/components/views/archives/ArchiveView.tsx Outdated Show resolved Hide resolved
projects/bp-gallery/src/components/views/discover/DiscoverView.tsx Outdated Show resolved Hide resolved
projects/bp-gallery/src/components/views/start/StartView.tsx Outdated Show resolved Hide resolved
projects/bp-gallery/src/hooks/get-pictures.hook.ts Show resolved Hide resolved
olschulz
olschulz approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@olschulz olschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elefantastisch!

@MariusDoe MariusDoe merged commit cceb5d4 into staging May 26, 2023
@MariusDoe MariusDoe deleted the 508-allow-users-to-show-most-liked-pictures branch May 26, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olschulz olschulz olschulz approved these changes

@MariusDoe MariusDoe MariusDoe approved these changes

@rheaSPK rheaSPK Awaiting requested review from rheaSPK

@ole1711 ole1711 Awaiting requested review from ole1711

@baerlach-git baerlach-git Awaiting requested review from baerlach-git

@DavidSchroschk DavidSchroschk Awaiting requested review from DavidSchroschk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to show most liked pictures
3 participants
@LinoH5 @MariusDoe @olschulz