-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes an issue in ContextS2 resulting from using class identity inste…
…ad of name when determining whether two partial methods are the same. As a result the partial method is not correctly removed in case of a recompile within a new class. (cherry-picked from commit b46aace)
- Loading branch information
1 parent
49546a7
commit de1e829
Showing
4 changed files
with
21 additions
and
0 deletions.
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
packages/Babylonian-Compiler.package/CSPartialMethod.extension/instance/^equals.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
*Babylonian-Compiler | ||
= anotherPartialMethod | ||
"see #hash" | ||
|
||
^ anotherPartialMethod class == self class | ||
and: [self basicLayers = anotherPartialMethod basicLayers | ||
and: [self selector = anotherPartialMethod selector | ||
and: [self methodClass name = anotherPartialMethod methodClass name]]] |
5 changes: 5 additions & 0 deletions
5
packages/Babylonian-Compiler.package/CSPartialMethod.extension/instance/hash.st
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
*Babylonian-Compiler | ||
hash | ||
"see #=" | ||
|
||
^ (self basicLayers hash bitXor: self selector hash) bitXor: self class name hash |
6 changes: 6 additions & 0 deletions
6
packages/Babylonian-Compiler.package/CSPartialMethod.extension/methodProperties.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"class" : { | ||
}, | ||
"instance" : { | ||
"=" : "sp 8/23/2023 14:35", | ||
"hash" : "sp 8/23/2023 14:36" } } |
2 changes: 2 additions & 0 deletions
2
packages/Babylonian-Compiler.package/CSPartialMethod.extension/properties.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
{ | ||
"name" : "CSPartialMethod" } |