realign screenshots

hpi-swa-lab · Dec 28, 2023 · f33a914 · f33a914 · github-actions · Dec 28, 2023
1 parent b1a9f5b
commit f33a914
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 16 deletions.
diff --git a/...es/TraceDebuggerJobs.package/TDBScreenshotBuilder.class/instance/createExampleShutDown.st b/...es/TraceDebuggerJobs.package/TDBScreenshotBuilder.class/instance/createExampleShutDown.st
@@ -6,10 +6,11 @@ createExampleShutDown
 		| window debugger tree splitter |
 		[TraceDebugger exampleShutDown] valueSuppressingMessages: #('*shutDown/startUp*').
 		window := helper foregroundWindow.
-		window extent: 564 @ 1538.
+		window extent: 564 px @ 1538 px.
 		debugger := window model.
 
 		tree := helper morphByExternalName: #contextTree in: window.
+		tree selectedMorph expand.
 		tree selectedMorph children do: #expand.
 		tree adjustSubmorphPositions.
 
@@ -19,5 +20,5 @@ createExampleShutDown
 
 		splitter := window allMorphs detect: [:m |
 			(m isKindOf: ProportionalSplitterMorph) and: [m splitsTopAndBottom] and: [m splitterAbove isNil]].
-		splitter splitterBelow repositionBy: 0 @ 150.
-		[window fullBounds. tree vIsScrollbarNeeded] whileTrue: [splitter repositionBy: 0 @ 1]]
+		splitter splitterBelow repositionBy: 0 @ 150 px.
+		[window fullBounds. tree vIsScrollbarNeeded] whileTrue: [splitter repositionBy: 0 @ 1 px]]
diff --git a/...raceDebuggerJobs.package/TDBScreenshotBuilder.class/instance/createHistoryExplorerList.st b/...raceDebuggerJobs.package/TDBScreenshotBuilder.class/instance/createHistoryExplorerList.st
@@ -4,18 +4,19 @@ createHistoryExplorerList
 	self recorder writeTo: 'screenshots/HistoryExplorer.png' building: [:helper |
 		| window explorer tree contextSlice |
 		window := TDBHistoryExplorer exampleRegex.
-		window height: 500.
+		window extent: 631 px @ 508 px.
 		explorer := window model.
 		explorer shouldShrinkColumns: true.
 		helper world fullBounds.
 
 		tree := helper morphByExternalName: #contextValueTree in: window.
-		contextSlice := tree items detect: [:item | item contents beginsWith: 'characterSet'].
+		contextSlice := tree items detect: [:item | '*match:*' match: item contents].
 
 		helper
 			click: tree
-			at: (tree pointAtFraction: 0.77) x @ (contextSlice boundsInWorld pointAtFraction: 0 @ 2 / 3) y
+			at: (tree pointAtFraction: 0.45) x @ (contextSlice boundsInWorld pointAtFraction: 0 @ 3 / 4) y
 			buttons: #(right).
 		helper closeBalloons.
+		helper menu y: helper menu y - 10 px.
 
 		helper tdbUpdateStyles].
diff --git a/...uggerJobs.package/TDBScreenshotBuilder.class/instance/createHistoryExplorerScreenshots.st b/...uggerJobs.package/TDBScreenshotBuilder.class/instance/createHistoryExplorerScreenshots.st
@@ -4,14 +4,14 @@ createHistoryExplorerScreenshots
 	self recorder writeInto: 'screenshots' recordSeries: [:recorder :helper |
 		| window explorer tree contextSlice |
 		window := TDBHistoryExplorer exampleRegex.
-		window height: 350.
+		window extent: 597 px @ 360 px.
 		explorer := window model.
 		explorer shouldShrinkColumns: true.
 		helper world fullBounds.
 
 		recorder writeTo: 'historyExplorerSmall.png' building: [helper tdbUpdateStyles].
 
-		window height: 400.
+		window height: 400 px.
 		helper world fullBounds.
 		tree := helper morphByExternalName: #contextValueTree in: window.
 		contextSlice := tree items detect: [:item | item contents endsWith: ''''].	

diff --git a/packages/TraceDebuggerJobs.package/TDBScreenshotBuilder.class/instance/createScreenshot.st b/packages/TraceDebuggerJobs.package/TDBScreenshotBuilder.class/instance/createScreenshot.st
@@ -6,11 +6,11 @@ createScreenshot
 		window := ['A' matchesRegex: '((?<=^)A)+'] traceAndDebug.
 		debugger := window model.
 
-		helper scaleWindow: window extent: 671 @ 523.
+		helper scaleWindow: window extent: 671 px @ 523 px.
 		splitter := window allMorphs detect: [:m |
 			(m isKindOf: ProportionalSplitterMorph) and: [m splitsTopAndBottom] and: [m splitterAbove isNil]].
-		splitter repositionBy: 0 @ 157.
-		splitter splitterBelow repositionBy: 0 @ 14.
+		splitter repositionBy: 0 @ 163 px.
+		splitter splitterBelow repositionBy: 0 @ 16 px.
 		helper world fullBounds.
 
 		[debugger findContext] valueSupplyingAnswer: #('*signature*' 'RxMatcher>>matchAgainstLookbehind:positive:nextLink: {matching}').
@@ -31,11 +31,12 @@ createScreenshot
 		child firstChild expand.
 		child firstChild firstChild expand.
 		tree adjustSubmorphPositions.
+		window fullBounds.
 		tree scrollToBottom.
 
 		helper click: tree at: (tree pointAtFraction: 4 / 5) x @ (tree selectedMorph boundsInWorld pointAtFraction: 4 / 5) y buttons: #(right).
 		helper closeBalloons.
 		helper menu
 			tdbRemoveAllSelectors: #(proceed restart stepInto stepOver stepThrough stepBack showWhere copyBugReportToClipboard);
 			tdbRemoveAllSelectors: #(offerMenuFrom:shifted:) reverse: true.
-		helper menu position: helper menu position + (-28 @ 12)].
+		helper menu position: helper menu position + (-20 px @ -2 px)].
diff --git a/packages/TraceDebuggerJobs.package/TDBScreenshotBuilder.class/methodProperties.json b/packages/TraceDebuggerJobs.package/TDBScreenshotBuilder.class/methodProperties.json
@@ -5,15 +5,15 @@
 		"screenshotSelectors" : "ct 7/31/2022 22:05" },
 	"instance" : {
 		"createContextToolTip" : "ct 12/28/2023 21:20",
-		"createExampleShutDown" : "ct 7/30/2022 16:38",
+		"createExampleShutDown" : "ct 12/28/2023 22:23",
 		"createExploreFieldHistory" : "ct 12/28/2022 03:53",
 		"createFindContext" : "ct 7/30/2022 16:38",
-		"createHistoryExplorerList" : "ct 7/29/2022 20:20",
+		"createHistoryExplorerList" : "ct 12/28/2023 22:24",
 		"createHistoryExplorerMorphConstruction" : "ct 12/29/2022 03:31",
 		"createHistoryExplorerMorphLayoutGIF" : "ct 7/29/2022 20:09",
-		"createHistoryExplorerScreenshots" : "ct 7/31/2022 02:58",
+		"createHistoryExplorerScreenshots" : "ct 12/28/2023 22:24",
 		"createInspectorScreenshots" : "ct 7/30/2022 16:38",
-		"createScreenshot" : "ct 12/28/2023 21:20",
+		"createScreenshot" : "ct 12/28/2023 22:24",
 		"createSpawnContext" : "ct 12/28/2023 21:20",
 		"createWindowMenu" : "ct 7/30/2022 16:38",
 		"recorder" : "ct 3/18/2022 03:04" } }