Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retracing foreign proxies #86

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

LinqLover
Copy link
Collaborator

@LinqLover LinqLover commented Jul 7, 2022

Follow-up of #85.

Main commit is 66702e3:

retracing: fix handling of foreign proxies

When encountering a proxy in a retracing simulator, also honor its time index or indices. Add abstract #timeIndex on TDBRetracingSimulator, also move up #contextPushRetracingTimeIndex: from point retracing simulator. Test proxy handling. For range retracing, handling of foreign range proxies is currently not possible, so mark this test as an expected failure.

Still todo: Update cursor implementation to no longer depend on the old behavior.

LinqLover and others added 4 commits July 7, 2022 18:22
This reverts commit 3ce72e3 "Revert 66702e3 for now"
Still, some tests reveal degraded performance and other fail. Requires further investigation.
This reverts commit 73a2d83.
LinqLover added a commit that referenced this pull request Jul 24, 2022
current todos and challenges:

* without #86, we cannot compare multiple proxies on the same object for different time indices
* in general, performance! with #86, comparing two proxies would trigger simCustomizationLevel = 2! but even without that problem, it might be very slow
* more proxy problems when trying to manually compare objects (because proxies often consist of shared memory slices)
* add tests, also for publicCoalesce:, and deduplicate coalescion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant