Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed logical OR to longer form #4

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Conversation

yeedle
Copy link
Contributor

@yeedle yeedle commented Feb 24, 2017

Addresses the bug mentioned in: #3

@hrbrmstr hrbrmstr merged commit 90e1936 into hrbrmstr:master Mar 11, 2017
@hrbrmstr
Copy link
Owner

#ty!

@hrbrmstr
Copy link
Owner

hrbrmstr commented Mar 11, 2017

Actually can you add yourself as a ctb to DESCRIPTION? This will be heading to CRAN in April and I def appreciate taking the time to file and issue and do the PR. It's a solid addition to the pkg. I'll add an Authors@R field in a sec

@yeedle
Copy link
Contributor Author

yeedle commented Mar 12, 2017

Wait, I just realized, this fix will cause an issue a little bit later in the code where you check the value of timespan again, without checking for nullity first. Submitting another pr. Sorry about that.

@hrbrmstr
Copy link
Owner

no worries. not on CRAN yet so it's in "use at own risk" territory ;-)

@yeedle
Copy link
Contributor Author

yeedle commented Mar 12, 2017

Question: As of now, even if user sets start and end time, timespan of "all" is still used, unless explicitly set to NULL or something else. Is that by design?

@hrbrmstr
Copy link
Owner

Kinda. I haven't quite figured out the best way to deal with the timespan selection. Def open to ideas here as the lack of a good pkg API is the main reason I haven't even pondered a CRAN release yet. I'm not convinced I've got a good API here (just a functional one) and am def open to any suggestions you may have.

It may mean making multiple query functions (which is totally cool) but I'm still not sure how folks want to engage with the pkg (I do cyber for a living and while I teach data science in my spare time at a few colleges here I'm not an investigative data journalist and rly want to ensure this pkg makes it easy for virtually anyone to find what they're looking for as easily as possible).

@yeedle
Copy link
Contributor Author

yeedle commented Mar 12, 2017

Good point. I've been using it here and there and so far it's been useful. Only suggestion I have so far is the one I tweeted at you

would be nice if can specify keywords and context keywords as vector of strings

@yeedle yeedle mentioned this pull request Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants