Fix activeParameter=-1 for jdtls #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrsh7th
reviewed
Feb 3, 2023
| @@ -99,7 +99,7 @@ source._item = function(self, signature, parameter_index) | |||
| parameter_index = (signature.activeParameter or parameter_index or 0) + 1 | |||
|
|
|||
| -- @see https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#signatureHelp | |||
| if #parameters < parameter_index then | |||
| if #parameters < parameter_index or parameter_index == 0 then | |||
There was a problem hiding this comment.
Should it be or parameter_index < 0?
There was a problem hiding this comment.
Well parameter_index will be 0 if activeParameter == -1 (line 99 above) and this leads to empty items.
But how about parameter_index < 1? This would also catch any other negative value for activeParameter.
There was a problem hiding this comment.
Yes. I think it should be.
We should support other negative values.
|
Thank you for your contribution. |
mikehaertl
force-pushed
the
fix-jdtls-signature-help
branch
from
924e6e8 to
3c3ff1f
Compare
|
LGTM. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse.jdt.ls often returns
-1foractiveParamer. This seems to be in line with the LSP specs.Current code only checks if
activeParameterlies above the upper limit but not if its below.Also see eclipse-jdtls/eclipse.jdt.ls#2434