Skip to content

Commit

Permalink
Skip tests that suddenly started failing for MinGW
Browse files Browse the repository at this point in the history
These test failures first appeared on irrelevant changes. It probably
came from changes in GitHub Actions instead of CRuby's.

Until we figure out how to fix these tests, let's skip them to make the
CI usable.
  • Loading branch information
k0kubun authored and hsbt committed Nov 6, 2024
1 parent b48a2d9 commit 7c5dec8
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions test/net/http/test_https.rb
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ def test_session_reuse_but_expire
omit if OpenSSL::OPENSSL_LIBRARY_VERSION.include?('OpenSSL 1.1.0h')
omit if OpenSSL::OPENSSL_LIBRARY_VERSION.include?('OpenSSL 3.2.')
omit if OpenSSL::OPENSSL_LIBRARY_VERSION.include?('OpenSSL 3.3.')
omit "not working on MinGW" if /mingw/ =~ RUBY_PLATFORM

http = Net::HTTP.new(HOST, config("port"))
http.use_ssl = true
Expand Down
1 change: 1 addition & 0 deletions test/openssl/test_x509req.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def test_public_key
end

def test_version
omit "not working on MinGW" if /mingw/ =~ RUBY_PLATFORM
req = issue_csr(0, @dn, @rsa1024, OpenSSL::Digest.new('SHA1'))
assert_equal(0, req.version)
req = OpenSSL::X509::Request.new(req.to_der)
Expand Down
1 change: 1 addition & 0 deletions test/ruby/test_argf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ def test_inplace_rename_impossible
end

def test_inplace_nonascii
omit "not working on MinGW" if /mingw/ =~ RUBY_PLATFORM
ext = Encoding.default_external or
skip "no default external encoding"
t = nil
Expand Down
3 changes: 3 additions & 0 deletions test/ruby/test_rubyoptions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ def test_autosplit
end

def test_chdir
omit "not working on MinGW" if /mingw/ =~ RUBY_PLATFORM
assert_in_out_err(%w(-C), "", [], /Can't chdir/)

assert_in_out_err(%w(-C test_ruby_test_rubyoptions_foobarbazqux), "", [], /Can't chdir/)
Expand Down Expand Up @@ -902,6 +903,7 @@ def test_command_line_glob_nonascii
end

def test_command_line_progname_nonascii
omit "not working on MinGW" if /mingw/ =~ RUBY_PLATFORM
bug10555 = '[ruby-dev:48752] [Bug #10555]'
name = expected = nil
unless (0x80..0x10000).any? {|c|
Expand Down Expand Up @@ -953,6 +955,7 @@ def assert_e_script_encoding(str, args = [])
# Since the codepage is shared all processes per conhost.exe, do
# not chcp, or parallel test may break.
def test_locale_codepage
omit "not working on MinGW" if /mingw/ =~ RUBY_PLATFORM
locale = Encoding.find("locale")
list = %W"\u{c7} \u{452} \u{3066 3059 3068}"
list.each do |s|
Expand Down

0 comments on commit 7c5dec8

Please sign in to comment.