Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accumulated miner share column #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sword-Smith
Copy link

A column for accumulated mining share is added on screens with a width over 640px.

This closes #63.

@hsjoberg
Copy link
Owner

Thank you for your well made pull request @Sword-Smith!

I am not sure I agree with adding this column however, sorry. My biggest concern is keeping the table simple.
I have added "Potential share" to the miners page, which would count the hashrate of all pools that have signaled at least once. Does this satisfy what you're trying to accomplish?

Cheers
Hampus

@Sword-Smith
Copy link
Author

I see your point. I was thinking this extra column would make it easier to conclude something along the lines with "we only need to convince these three mining pools to get our proposal through".

@hsjoberg hsjoberg force-pushed the master branch 6 times, most recently from e728962 to 69f7f8d Compare May 23, 2021 21:07
@Sword-Smith
Copy link
Author

Sword-Smith commented May 24, 2021

But obviously your call. Add it if you think it is useful, don't if you don't. Furthermore a slight modification to the presentation of this number would probably be desired now that you have added sorting options for each column.

@hsjoberg hsjoberg force-pushed the master branch 2 times, most recently from abe91ca to b77db80 Compare June 17, 2021 16:37
Joseph1417

This comment was marked as spam.

Repository owner deleted a comment from Joseph1417 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miners: Add new column to show accumulated share
3 participants