Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shardReader for grpc-haskell #1525

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix shardReader for grpc-haskell #1525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hstream/src/HStream/Server/Handler/ShardReader.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ readShardStreamHandler sc (ServerWriterRequest _meta req streamSend) =
defaultServerStreamExceptionHandle $ do
Log.debug $ "Receive read shard stream Request: " <> Log.build (show req)
C.readShardStream sc req streamWrite
return $ ServerWriterResponse mempty StatusUnknown "should not reach here"
returnServerStreamingResp StatusOk ""
where
streamWrite x = first show <$> streamSend x

Expand All @@ -135,7 +135,7 @@ readStreamHandler sc (ServerWriterRequest _meta req streamSend) =
defaultServerStreamExceptionHandle $ do
Log.debug $ "Receive read shard stream Request: " <> Log.build (show req)
C.readStream sc req streamWrite
return $ ServerWriterResponse mempty StatusUnknown "should not reach here"
returnServerStreamingResp StatusOk ""
where
streamWrite x = first show <$> streamSend x

Expand All @@ -154,7 +154,7 @@ readSingleShardStreamHandler sc (ServerWriterRequest _meta req streamSend) =
defaultServerStreamExceptionHandle $ do
Log.debug $ "Receive read single shard stream Request: " <> Log.build (show req)
C.readSingleShardStream sc req streamWrite
return $ ServerWriterResponse mempty StatusUnknown "should not reach here"
returnServerStreamingResp StatusOk ""
where
streamWrite x = first show <$> streamSend x

Expand Down