Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only change the time a beer was added to a tap if the beer changed #199

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

drewbrew
Copy link
Contributor

Related to #198 but I put it in a separate PR for discussion:

Do we want to override the APIs and only update the time added if the beer changed?

Pros

  • Flagships like Monkeynaut and Rebellion won't be continually "freshly tapped"

Cons

  • It'll obscure when a keg is fresh if it happened to replace what was just on with itself.

@drewbrew drewbrew force-pushed the only-update-time-added-if-beer-changed branch from 2e0bc1a to 499586b Compare May 22, 2019 13:59
@drewbrew drewbrew added the help wanted Extra attention is needed label May 22, 2019
@drewbrew drewbrew force-pushed the only-update-time-added-if-beer-changed branch from 499586b to 4ee73fd Compare May 29, 2019 15:40
@drewbrew drewbrew force-pushed the only-update-time-added-if-beer-changed branch from 87a3e8e to e5d96e1 Compare July 23, 2019 21:51
drewbrew added 25 commits July 23, 2019 16:58
Base automatically changed from master to main March 9, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant