-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only change the time a beer was added to a tap if the beer changed #199
Open
drewbrew
wants to merge
40
commits into
main
Choose a base branch
from
only-update-time-added-if-beer-changed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbrew
force-pushed
the
only-update-time-added-if-beer-changed
branch
from
May 22, 2019 13:59
2e0bc1a
to
499586b
Compare
drewbrew
force-pushed
the
only-update-time-added-if-beer-changed
branch
from
May 29, 2019 15:40
499586b
to
4ee73fd
Compare
drewbrew
force-pushed
the
only-update-time-added-if-beer-changed
branch
from
July 23, 2019 21:51
87a3e8e
to
e5d96e1
Compare
…ded-if-beer-changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #198 but I put it in a separate PR for discussion:
Do we want to override the APIs and only update the time added if the beer changed?
Pros
Cons