Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty XML nodes are stripped before sending payload #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Empty XML nodes are stripped before sending payload #4

wants to merge 2 commits into from

Conversation

igniteflow
Copy link

Empty XML nodes were breaking a SOAP webservice I was dealing with, so I have added a simple regex to strip them before sending the payload. Not sure if this behaviour could have any potential negative impact, so will leave the decision up to the maintainer as to whether to accept this pull request.

@htj
Copy link
Owner

htj commented Feb 27, 2013

Hi, I don't really use SUDS anymore (to many bugs), and don't really want to spend any time on it. Sorry

Regarding the patch. While it solves the problem, it is not really a proper fix for it, so I'd prefer to not to merge it.

@igniteflow
Copy link
Author

No problem, I'm not the biggest fan of SUDS either. What are you using now
out of interest? Or have you escaped from having to interact with SOAP
webservices?

On 27 February 2013 10:16, Henrik Thostrup Jensen
[email protected]:

Hi, I don't really use SUDS anymore (to many bugs), and don't really want
to spend any time on it. Sorry

Regarding the patch. While it solves the problem, it is not really a
proper fix for it, so I'd prefer to not to merge it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-14166255
.

@htj
Copy link
Owner

htj commented Feb 27, 2013

Haven't escaped SOAP, unfortunately :-)

I am using generateDS for generating bindings from XSD, and have written my own thin SOAP handling on top of that. The generateDS bindings may need a little massage to work, but they are much faster than SOAP, and when something is wrong I can actually figure out what is wrong, which was largely impossible with SUDS.

@igniteflow
Copy link
Author

Agreed that debugging SUDS when things go wrong is truly horrible
experience. If you have or ever plan to open-source your library, I'd be
interested to see it. Experience tells me that the thinner the wrapper the
better, especially when it comes to SOAP.

On 27 February 2013 10:40, Henrik Thostrup Jensen
[email protected]:

Haven't escaped SOAP, unfortunately :-)

I am using generateDS for generating bindings from XSD, and have written
my own thin SOAP handling on top of that. The generateDS bindings may need
a little massage to work, but they are much faster than SOAP, and when
something is wrong I can actually figure out what is wrong, which was
largely impossible with SUDS.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-14167136
.

@htj
Copy link
Owner

htj commented Feb 27, 2013

Code is here: http://git.nordu.net/?p=opennsa.git (git clone git://git.nordu.net/opennsa.git). It is under a BSD license (company policy).

You want to look under opennsa/protocols/shared and nsi2 for how it is used. The approach requires a bit of grunt work, but works pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants