-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies to fix security issues #485
Updated dependencies to fix security issues #485
Conversation
Thanks for sending these! We've actually got quite a tangle of dependencies that need upgrading (or removing/reconsidering). @thornjad not sure if this is the "tip of the spear" in that regard or not, but certainly bumping all the versions is important before the next major (and possibly next minor--if we can avoid BC breaks) release. |
I certainly agree this is important. However I do think we need to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part, I would prefer to leave most of these with the ^
(meaning any minor version greater than the one specified), so we don't have to update package.json
often. To that end, I'd request that most if not all of the package version here start with ^
.
Apparently the version of |
@lvl99 you're right, and it's already fixed in the next version of @chill117 would you mind changing this to use version ranges instead of specific versions? You can also mark this as addressing #461 |
Removed common-style (deprecated, depends on unpatched packages) Issue #461
I've updated the version numbering to include ~ and ^ where appropriate. I returned common and the pretest for code-style checking - to limit the scope of this PR to updating non-dev dependencies. |
...ps-to-fix-security-issues Updated dependencies to fix security issues
Removed common-style (deprecated, depends on unpatched packages)