Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the passphrase option for a PEM certification - fix #162
I had to copy and paste some code from the union library (trimmed as much as possible) to add a shim to enable configuring ssl passphrase
What changes did you make?
Added the option to read passphrase (from environment variable as recommended in previous conversations)
Added a shim to allow for the missing functionality from union
Updated README to reflect the new option, with an example of creating a cert
Provide some example code that this change will affect, if applicable:
Is there anything you'd like reviewers to focus on?
I realise this might be controversial, but given that union has not been updated in some time I think this is an ok short-term solution until a longer term one is implemented, either:
Of all these options I think the best one is to find a replacement for union, but as a relative newcomer to this code-base I'm not sure specifically what functions this library is supporting nor am I brave enough (yet) to do any major refactoring.
Please ensure that your pull request fulfills these requirements:
master
branchhttp-server --help
text (n/a)What is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Enhancement / new feature - #162