Skip to content

Commit

Permalink
Give up (maybe temporarily) calling `PgPoolOptions.setUpConventionall…
Browse files Browse the repository at this point in the history
…y` because the following error occurs probably when calling `withTransaction` in an internal project:

```
Cannot acquire a connection on a pipelined pool
io.vertx.core.impl.NoStackTraceThrowable: Cannot acquire a connection on a pipelined pool
```
  • Loading branch information
ShreckYe committed Nov 26, 2024
1 parent 74dca80 commit 4c64c62
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import com.huanshankeji.exposedvertxsqlclient.vertx.sqlclient.CoConnectHandler
import com.huanshankeji.exposedvertxsqlclient.vertx.sqlclient.createGenericSqlClient
import com.huanshankeji.exposedvertxsqlclient.vertx.sqlclient.createGenericSqlClientWithBuilder
import com.huanshankeji.exposedvertxsqlclient.vertx.sqlclient.createGenericSqlConnection
import com.huanshankeji.vertx.pgclient.setUpConventionally
import io.vertx.core.Vertx
import io.vertx.pgclient.PgBuilder
import io.vertx.pgclient.PgConnectOptions
Expand Down Expand Up @@ -60,8 +59,6 @@ fun createPgClient(
)

/**
* [PgPoolOptions.pipelined] is enabled by default.
* @see PgPoolOptions.setUpConventionally
* @see createGenericSqlClient
*/
fun createPgPool(
Expand All @@ -76,10 +73,7 @@ fun createPgPool(
connectionConfig,
PgBuilder.pool(),
extraPgConnectOptions,
{
setUpConventionally()
extraPoolOptions()
},
extraPoolOptions,
connectHandlerExtra
)

Expand Down

1 comment on commit 4c64c62

@ShreckYe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is final because one can't use transactions with pipelining with the current Vert.x SQL client.

Please sign in to comment.