-
Notifications
You must be signed in to change notification settings - Fork 79
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Description This PR includes #2803 and #2790 Removed from version 1.0.0-dev - botonic-api - botonic-pulumi - create-botonic-app package Removes old AI packages that we won't update anymore - botonic-nlp - botonic-intent-classification - botonic-ner Removes the package-lock.json from each package Add the examples folder to the monorepo with the https://github.com/hubtype/botonic-examples but examples using @botonic/dx in the devDependencies and the new version of @botonic/react With node 20 you use npm 10. With npm 10 I created a monorepo using npm workspaces. With this monorepo you do `npm install` in the root of the project and this creates a shared node_modules in the root. You can run scripts for each package from the botonic root. For example `npm run build -w @botonic/core` Change several things about how builds are done using tsc. It adds a tsconfig.esm.base.json and tsconfig.cjs.base.json to the root of the project and extends these two files to create the builds of all packages. ## Context This PR updates many dependencies such as Node, npm, webpack (webpack plugin), jest, eslint (eslint plugins), prettier, axios, etc. It also updates the github actions so that builds are done properly when running tests in the repository. ## Approach taken / Explain the design When using an npm monorepo, symlink internal to the monorepo is used. When using symlink it is necessary to build @botonic/core before making changes to a package that requires `@botonic/core`. For example if you want to change `@botonic/react` code you need to build `@botonic/core` to make the imports work, pass the lint, pass the tests etc. This is also important in the github actions. now you can declare a BUILD_COMMAND for cases where you need to build core first. ## To document / Usage example To start developing using all these new versions of node, npm, monorepo, etc. - Remove all package-lock.json, all node_modules and lib folders - With nvm (or similar) use node 20 and npm 10 - From root folder do an `npm i` - Then an npm build on `@botonic/core` - Then an npm build on `@botonic/react` ## Testing All the tests that already existed are still running locally and in the GitHub repository. Update a @botonic/cli deploy.test.ts that used an example published in the master branch of the external @botonic-examples repository. Now use the examples folder inside the monorepo so that changes can be made and tests can be tested before releasing the example bot version. --------- Co-authored-by: Marc Rabat <[email protected]>
- Loading branch information
1 parent
8c11085
commit f038bce
Showing
818 changed files
with
40,843 additions
and
71,109 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
.github/workflows/botonic-plugin-intent-classification-tests.yml
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.