Downgrade missing metadata file to <check_failure> when validation model output files. (#138)

R/check_submission_metadata_file_exists.R

@@ -38,6 +38,6 @@ check_submission_metadata_file_exists <- function(file_path, hub_path = ".") {
     msg_subject = "Metadata file",
     msg_attribute = msg_attribute,
     msg_verbs = c("exists", "does not exist"),
-    error = TRUE
+    error = FALSE
   )
 }

R/validate_model_file.R

@@ -91,9 +91,6 @@ validate_model_file <- function(hub_path, file_path,
       file_path = file_path
     ), file_path
   )
-  if (is_any_error(checks$metadata_exists)) {
-    return(checks)
-  }
 
   custom_checks <- execute_custom_checks(validations_cfg_path = validations_cfg_path)
   checks <- combine(checks, custom_checks)

inst/check_table.csv

@@ -6,7 +6,7 @@ file_name,File name valid,TRUE,check_error,validate_model_file,check_file_name,,
 file_location,File located in correct team directory,FALSE,check_failure,validate_model_file,check_file_location,,FALSE
 round_id_valid,File round ID is valid hub round IDs,TRUE,check_error,validate_model_file,check_valid_round_id,,FALSE
 file_format,File format is accepted hub/round format,TRUE,check_error,validate_model_file,check_file_format,,FALSE
-metadata_exists,Model metadata file exists in expected location,TRUE,check_error,validate_model_file,check_submission_metadata_file_exists,,FALSE
+metadata_exists,Model metadata file exists in expected location,FALSE,check_failure,validate_model_file,check_submission_metadata_file_exists,,FALSE
 file_read,File can be read without errors,TRUE,check_error,validate_model_data,check_file_read,,FALSE
 valid_round_id_col,Round ID var from config exists in data column names. Skipped if `round_id_from_var` is FALSE in config.,FALSE,check_failure,validate_model_data,check_valid_round_id_col,,FALSE
 unique_round_id,Round ID column contains a single unique round ID. Skipped if `round_id_from_var` is FALSE in config.,TRUE,check_error,validate_model_data,check_tbl_unique_round_id,,FALSE

tests/testthat/_snaps/check_submission_metadata_file_exists.md

@@ -12,7 +12,7 @@
     Code
       check_submission_metadata_file_exists(hub_path = hub_path, file_path = "random-model/2022-10-01-random-model.csv")
     Output
-      <error/check_error>
+      <error/check_failure>
       Error:
       ! Metadata file does not exist at path 'model-metadata/random-model.yml' or 'model-metadata/random-model.yaml'.
 

tests/testthat/test-validate_pr.R

@@ -63,6 +63,10 @@ test_that("validate_pr flags modifications and deletions in PR", {
     branch = "test-mod-del"
   )
 
+  # This checks that removed metadata and model-output files are detected and
+  # flagged as check errors.
+  # It also checks that missing metadata files do not cause early return
+  # of submission validation of model output file.
   mod_checks_error <- suppressMessages(
     validate_pr(
       hub_path = temp_hub,
@@ -90,6 +94,10 @@ test_that("validate_pr flags modifications and deletions in PR", {
     )
   )
 
+  # This checks that removed metadata and model-output files are detected and
+  # flagged as check failure.
+  # It also checks that missing metadata files do not cause early return
+  # of submission validation of model output file.
   mod_checks_warn <- suppressMessages(
     validate_pr(
       hub_path = temp_hub,