Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old process for saving metatile labels goes like this:
metatile_labels.h
metatile_labels.h
, using a regex to determine which tileset each set of defines belongs toWe have a map of metatile labels from when
metatile_labels.h
was first parsed, so parsing it again is unnecessary. We also don't need to try and determine which tileset each belongs to when saving (we already know at this point). Now we just refresh this map with the defines for the tilesets being saved, then use this map to regeneratemetatile_labels.h
. This would discard any definitions that don't belong to an existing tileset, so we now save those separately (this has the added benefit of not printing// gTileset_Name
comments in this file for non-existent tilesets). Closes #530Note: Porymap (as before) does not prevent users from naming tilesets in a way that can cause metatile labels to collide (e.g. if we have
gTileset_Foo
andgTileset_Foo_Bar
, the ownership ofMETATILE_Foo_Bar_Baz
is ambiguous).