Fix bug whereby note without a type caused an error on export

hudmol · May 20, 2022 · b8e343f · b8e343f
1 parent 2350cef
commit b8e343f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/backend/model/spreadsheet_builder.rb b/backend/model/spreadsheet_builder.rb
@@ -337,7 +337,7 @@ def calculate_subrecord_counts(min_subrecords, extra_subrecords, min_notes)
         .select(:archival_object_id, :notes)
         .each do |row|
         note_json = JSON.parse(row[:notes])
-        note_type = note_json.fetch('type')
+        note_type = note_json.fetch('type', 'NOT_SUPPORTED')
 
         notes_max_counts[note_type] ||= 0
         notes_max_counts[note_type] += 1
@@ -685,7 +685,7 @@ def dataset_iterator(&block)
           .each do |row|
           note_json = ASUtils.json_parse(row[:notes])
 
-          note_type = note_json.fetch('type').intern
+          note_type = note_json.fetch('type', 'NOT_SUPPORTED').intern
 
           next unless (MULTIPART_NOTES_OF_INTEREST + SINGLEPART_NOTES_OF_INTEREST).include?(note_type)
           next unless selected?("note_#{note_type}")