Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

fix: free storage pointer used in param bug #235

Merged
merged 4 commits into from
Jan 15, 2023
Merged

fix: free storage pointer used in param bug #235

merged 4 commits into from
Jan 15, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Dec 28, 2022 •
edited
Loading

Overview

Fixes #234

TODO

  • Further tests
  • Tracing cleanup

@Maddiaa0 Maddiaa0 marked this pull request as draft December 28, 2022 16:25
@Maddiaa0 Maddiaa0 requested a review from refcell December 29, 2022 18:43
@Maddiaa0 Maddiaa0 marked this pull request as ready for review December 29, 2022 18:45
@Maddiaa0 Maddiaa0 requested a review from clabby January 3, 2023 23:45
@clabby
Copy link
Member

clabby commented Jan 4, 2023

Will try to get around to reviewing this tomorrow or Thurs, thanks!

clabby
clabby approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay on review, this got buried in my notifs 😅

@clabby clabby merged commit c4bdf53 into stage Jan 15, 2023
@Maddiaa0 Maddiaa0 deleted the md/free-slot-bug branch January 15, 2023 15:05
@Maddiaa0 Maddiaa0 mentioned this pull request Jan 28, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clabby clabby clabby approved these changes

@refcell refcell Awaiting requested review from refcell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maddiaa0 @clabby