Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

Throw error on macro name clash #293

Merged
merged 8 commits into from
Oct 1, 2023

Conversation

PraneshASP
Copy link
Contributor

Resolves #291.

Tried running cargo +nightly clippy --all --all-features -- -D warnings,fails with some errors the main branch as well.

@Maddiaa0 Maddiaa0 self-assigned this Sep 10, 2023
@Maddiaa0 Maddiaa0 changed the base branch from main to stage September 10, 2023 21:32
@Maddiaa0 Maddiaa0 force-pushed the fix/duplicate-macro-error branch from c8ffae5 to 96e7c8d Compare September 10, 2023 22:08
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've re-based this onto stage and ran clippy --fix, Have some small comments!

huff_parser/src/lib.rs Outdated Show resolved Hide resolved
huff_parser/src/lib.rs Show resolved Hide resolved
huff_parser/tests/macro.rs Outdated Show resolved Hide resolved
@PraneshASP PraneshASP requested a review from Maddiaa0 September 30, 2023 14:55
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Maddiaa0 Maddiaa0 merged commit 09d7a24 into huff-language:stage Oct 1, 2023
@Maddiaa0 Maddiaa0 mentioned this pull request Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler doesn't fail on "macro clash"
2 participants