Remove huggingface_hub install that is no longer needed in the kubernetes example #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dmsuehir <[email protected]>
regisss
approved these changes
Aug 23, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
pushed a commit
that referenced
this pull request
Aug 23, 2024
…etes example (#1286) Signed-off-by: dmsuehir <[email protected]>
KimBioInfoStudio
pushed a commit
to KimBioInfoStudio/optimum-habana
that referenced
this pull request
Aug 26, 2024
…etes example (huggingface#1286) Signed-off-by: dmsuehir <[email protected]>
atakaha
pushed a commit
to atakaha/optimum-habana
that referenced
this pull request
Sep 3, 2024
…etes example (huggingface#1286) Signed-off-by: dmsuehir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
huggingface_hub was being specified in the requirements.txt because optimum habana v1.12.0 was using huggingface_hub < 0.23.0, and the Kubernetes workflow required huggingface_hub 0.23.0+ in order to use
HF_TOKEN_PATH, as explained here. Since 1.13.0 is using huggingface_hub >= 0.23.2, we can remove huggingface_hub from the requirements.txt.I tested this change by rebuilding the container, and running the kubernetes example using a gated model to verify that the
HF_TOKEN_PATHis working.Before submitting