Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert_close by assert_similar in tests #112

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Replace assert_close by assert_similar in tests #112

merged 1 commit into from
Mar 7, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Mar 6, 2024

The assert_close helper often fails when comparing small values, so it is removed and assert_similar is now used everywhere.

This should fix #105.

SunMarc
SunMarc approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

younesbelkada
younesbelkada approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@dacorvo dacorvo merged commit cafe14b into main Mar 7, 2024
3 checks passed
@dacorvo dacorvo deleted the remove_assert_close branch March 7, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

@SunMarc SunMarc SunMarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch matrix multiplication test fails for MPS device on float16 precision
3 participants
@dacorvo @younesbelkada @SunMarc