-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests and examples on CUDA #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacorvo
force-pushed
the
cuda_examples
branch
5 times, most recently
from
July 22, 2024 15:17
78a7c07
to
b95ad45
Compare
The GEMM kernel crashes if output features are less than 128. It is unclear if the issue comes from: - the kernel itself, - a wrong packing/formatting of the inputs (padding might be required), - a wrong evaluation of the kernel parameters. As a workaround, both GEMM and GEMV kernels are disabled if the number of output features is less than 128. Eventually, only the unpacking code should remain in quanto, and the AWQ kernels should be replaced by the latest MARLIN kernels that are better maintained.
dacorvo
force-pushed
the
cuda_examples
branch
2 times, most recently
from
July 22, 2024 16:22
001b031
to
c8d3910
Compare
We need to install the package in editable mode, because otherwise extension files are not properly installed. This probably comes from a wrong behaviour of `setuptools_scm`, since it is in charge of detecting package assets automatically.
Without explicitly binding the CUDA device to the CI container, all unit tests running on the CUDA device were previously skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull-request: