New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tool call response to adhere to OpenAI spec #2949

Open

Datta0 wants to merge 2 commits into huggingface:main from Datta0:tool_call_output

+36 −9

Datta0 commented Jan 24, 2025

What does this PR do?

OpenAI tool call arguments field is supposed to be string. TGI seems to output a JSON. Fix it.
ToolCalls in streaming case should be a list of tool calls, TGI outputs singular tool call. So update the struct accordingly.

Datta0 added 2 commits

January 24, 2025 09:19


          Fix tool call response to adhere to OpenAI spec


          Make tool_call a list for streaming case

f709466

Datta0 marked this pull request as ready for review

January 24, 2025 09:50

Trofleb mentioned this pull request

General fixes for tool calling #2954

Open

4 tasks

drbh self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet