Add strftime_now callable function for minijinja chat templates
#2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarobartt
changed the title
chrono and strftime_now function callablestrftime_now callable function
alvarobartt
changed the title
strftime_now callable functionstrftime_now callable function for minijinja chat templates
kldzj
approved these changes
Feb 1, 2025
danieldk
pushed a commit
that referenced
this pull request
Feb 4, 2025
…2983) * Add `chrono` and `strftime_now` function callable * Fix `test_chat_template_valid_with_strftime_now` * Fix `test_chat_template_valid_with_strftime_now`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
strftime_nowcallable function supported by the Hugging Face chat templates as per https://huggingface.co/docs/transformers/en/chat_templating#callable-functions, which was not yet supported on TGI.It was leading to some models fail, such as the recent Mistral Small models i.e. https://huggingface.co/mistralai/Mistral-Small-24B-Base-2501 and https://huggingface.co/mistralai/Mistral-Small-24B-Instruct-2501, because the callable was not supported.
Thanks to @andrewrreed for reporting internall!
Before submitting
Who can review?
@OlivierDehaene OR @Narsil