Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LZ4 compression usage to CasObject #17

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Add LZ4 compression usage to CasObject #17

merged 2 commits into from
Sep 20, 2024

Conversation

rajatarya
Copy link
Collaborator

  • LocalClient does not use compression
  • RemoteClient does
  • Also has unit-tests.
  • Refactored CompressionScheme enum out of cas::common / utils.

@rajatarya
Consolidate CompressionScheme enum
76a5244 
- removed from utils crate
- moved from cas_types crate to cas_object
@rajatarya
Adds LZ4 compression, with unit-tests
abe67e9
assafvayner
assafvayner approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@assafvayner assafvayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rajatarya rajatarya merged commit 9392e59 into main Sep 20, 2024
1 check passed
@rajatarya rajatarya deleted the rajat/use-compression branch September 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assafvayner assafvayner assafvayner approved these changes

@seanses seanses Awaiting requested review from seanses

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajatarya @assafvayner