CasObject validation with updated tests #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rajatarya
commented
Sep 24, 2024
rajatarya
commented
- also added Copy trait to HexMerkleHash struct
- also added Copy trait to HexMerkleHash struct
assafvayner
approved these changes
Sep 24, 2024
cas_object/src/cas_object_format.rs
Outdated
Comment on lines
559
to
563
| if idx == 0 && c.start_byte_index != 0 { | ||
| // for 1st chunk verify that its start_byte_index is 0 | ||
| warn!("XORB Validation: Byte 0 does not contain 1st chunk."); | ||
| return Ok(false); | ||
| } |
There was a problem hiding this comment.
can we move this outside the loop to check the 1 value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.