Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change knox to aws-sdk in order to support v4 aws signatures #30

Closed
wants to merge 2 commits into from

Conversation

andreialecu
Copy link

See #29

There are some minor potential breaking changes since now aws-sdk style parameters are expected instead of knox style parameters.

So for example headers will now expect CacheControl instead of the HTTP Cache-Control knox works with.

@antony
Copy link

antony commented Apr 12, 2016

Any chance of this making it into the main codebase? The library is simply broken in frankfurt without it.

@jrbenito
Copy link

@hughsk,

This is really an important feature. Could you please merge this and bump version on npm?

Thanks

@andreialecu
Copy link
Author

You can use my fork at https://github.com/andreialecu/s3-sync-aws which has this.

It's also on npm as s3-sync-aws

@andreialecu andreialecu closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants