Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bootstrap 5 #918

Merged
merged 8 commits into from
Apr 20, 2024
Merged

Migrate to Bootstrap 5 #918

merged 8 commits into from
Apr 20, 2024

Conversation

BernatBC
Copy link
Member

@BernatBC BernatBC commented Apr 1, 2024

Issue

Fixes #906

Description

Migrate Bootstrap 4 to 5.

I've done some testing, but there might be something odd (specially if the config is different than hugo-toha.github.io). If anyone finds some bugs, please tell me.

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit e6520ae
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/66241dd32d2a0900087e893f
😎 Deploy Preview https://deploy-preview-918--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BernatBC BernatBC marked this pull request as ready for review April 1, 2024 18:15
@hossainemruz
Copy link
Member

Thank you @BernatBC! I will take a look soon. From checking the deploy preview, look like the drop downs are not working.

@BernatBC
Copy link
Member Author

BernatBC commented Apr 1, 2024

Looks like I forgot to update Bootstrap to 5 in the example site. Now it should work.

@BernatBC
Copy link
Member Author

BernatBC commented Apr 1, 2024

For some reason it's not working in the preview, but it's fine locally.

@hossainemruz hossainemruz added the enhancement New feature or request label Apr 20, 2024
@hossainemruz
Copy link
Member

hossainemruz commented Apr 20, 2024

@BernatBC I have pushed few changes. They fixes the following issues:

  1. Scroll spy was not working
  2. Dropdown was not working
  3. Card had accent color title instead of text color
  4. Navbar brand title had text decoration
  5. Sidebar and navbar switcher had border around them.
  6. Scroll-to-top button had outline around it

I am pretty sure more issues will pop up. However, I think it is good enough for now. We will fix them when user reports them.

@hossainemruz
Copy link
Member

For some reason it's not working in the preview, but it's fine locally.

Apparently, you forgot to update package.hugo.json which is used to generate package.json for the sites that uses this theme.

@hossainemruz hossainemruz merged commit 03148c9 into hugo-toha:main Apr 20, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap 5
2 participants