Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addOptionalHostPermissions #12

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Add addOptionalHostPermissions #12

merged 1 commit into from
Mar 24, 2024

Conversation

yescallop
Copy link
Contributor

@yescallop yescallop commented Mar 24, 2024

In order to solve huhu/rust-search-extension#263, we need to make the "Allow access to file URLs" setting show. I suggest we use this solution:

I ended up adding "optional_host_permissions": [ "file:///*" ]
This way the "Allow access to file URLs" is shown, navigation works, but I don't actually get read permission.

The next part of the fix is at huhu/rust-search-extension#275. Thank you for your attention.

Copy link
Member

@Folyd Folyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Folyd Folyd merged commit d273f00 into huhu:master Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants