Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Single Logout Protocol #26

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gonzomir
Copy link
Contributor

@gonzomir gonzomir commented Nov 1, 2018

This fixes #5. Thoe workflow is are as follows:

  1. The user logs out from Wordpress.
    1. After the user has been signed out the plugin send logout request to IdP's SLS.
    2. The IdP logs out the user and sends logout response to sso/sls endpoint.
    3. After processing the response the plugin redirects the user to the original redirect URL or /wp-admin
  2. The user logs out from IdP or another SP.
    1. The IdP sends logout request to sso/sls endpoint with a redirect.
    2. The plugin signs out the user and sends logout response to IdP with redirect.

@spacedmonkey
Copy link

@shadyvb Any chance of merging this?

Copy link
Contributor

@shadyvb shadyvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to do some testing this week before merging.

Thanks @spacedmonkey !

@spacedmonkey
Copy link

Any chance this can get merged? @shadyvb

@spacedmonkey
Copy link

Updated PR to stop fatal error.

@spacedmonkey
Copy link

In Skyscanner#7 it makes the settings more filter so SLS can be filtered to pass other params to wpsimplesaml_idp_metadata filter.

In Skyscanner#6 I fixed the error message.

@tlaverdure
Copy link

Hey there, was wondering if there were any plans to get this merged soon? Need this to fulfill a high priority security requirement. Thanks!

@stedaniels
Copy link

@shadyvb what needs to be done to get this merged? Anything I can help out on?

],
'NameIDFormat' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress',
];
$settings['sp']['entityId'] = $sp_home_url;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't guarantee $settings['sp'] is set any more.

Suggested change
$settings['sp']['entityId'] = $sp_home_url;
if ( ! isset( $settings['sp'] ) {
$settings['sp'] = [];
}
$settings['sp']['entityId'] = $sp_home_url;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the Single Logout Service endpoint
7 participants