-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Single Logout Protocol #26
base: master
Are you sure you want to change the base?
Conversation
@shadyvb Any chance of merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need to do some testing this week before merging.
Thanks @spacedmonkey !
Any chance this can get merged? @shadyvb |
Updated PR to stop fatal error. |
Fix SLS error message
Make filter more useful.
In Skyscanner#7 it makes the settings more filter so SLS can be filtered to pass other params to In Skyscanner#6 I fixed the error message. |
Hey there, was wondering if there were any plans to get this merged soon? Need this to fulfill a high priority security requirement. Thanks! |
@shadyvb what needs to be done to get this merged? Anything I can help out on? |
], | ||
'NameIDFormat' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress', | ||
]; | ||
$settings['sp']['entityId'] = $sp_home_url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't guarantee $settings['sp']
is set any more.
$settings['sp']['entityId'] = $sp_home_url; | |
if ( ! isset( $settings['sp'] ) { | |
$settings['sp'] = []; | |
} | |
$settings['sp']['entityId'] = $sp_home_url; |
This fixes #5. Thoe workflow is are as follows:
sso/sls
endpoint./wp-admin
sso/sls
endpoint with a redirect.