Fix spline steering method when path length != 1 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a note in the documentation of |
|
Related to #307 |
Yes, it is done. |
|
@nim65s could this be released in robotpkg ? |
|
On my computer, the test introduced after this pull request (1e57011) does not pass. |
|
The test fails before I installed but passes after I installed. Did you install the package ? |
|
Yes. It passes after installing. Thank you. |
|
The patch is on its way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spline steering method can take as the desired path length as input (#298) but the right hand side was not updated accordingly. This fixes it and adds a test with a robotic arm robot.
Note that the same test with Romeo fails when checking the velocities because the spline steering method does not handle rotations correctly. Not sure if it should throw an exception or a warning in that case.