Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization to manga #1305

Open
wants to merge 2 commits into
base: the-future
Choose a base branch
from
Open

Add serialization to manga #1305

wants to merge 2 commits into from

Conversation

shomykohai
Copy link
Contributor

@shomykohai shomykohai commented Jan 15, 2023 •
edited
Loading

What

Add serialization field to Manga in the GraphQL API

Why

The field in the current production GraphQL API is missing, but it's present in JSON:API

Checklist

  • All files pass Rubocop
  • Any complex logic is commented
  • Any new systems have thorough documentation
  • Any user-facing changes are behind a feature flag (or: explain why they can't be)
  • All the tests pass
  • Tests have been added to cover the new code

@shomykohai shomykohai marked this pull request as ready for review January 15, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shomykohai