Replace Canny with Nolt (closes #775) #1107
Conversation
matthewdias
changed the title
matthewdias
force-pushed
the
feature/nolt
branch
from
98aab24
to
e6ada64
Compare
| @@ -13,15 +13,14 @@ function adwords() { | |||
| } | |||
|
|
|||
| /** | |||
| * Inject Canny's SDK script into the `head` on initialization. | |||
| * Inject Nolt's SDK script into the `head` on initialization. | |||
|
Thank you for doing this! |
|
SSO (with Edit: Nvm, looks like it's calling a query that hasn't been merged/deployed on production
|
Rather than data.authenticated.access_token
|
Ah yep my bad forgot to note it uses this branch. https://github.com/hummingbird-me/kitsu-server/tree/nuck/nolt-sso |
|
lmk when you've got that branch updated and I can give it 👀 pretty quick |
|
LGTM! Don't merge until the server side has been deployed to production yet though - I deploy |
|
Waiting on hummingbird-me/kitsu-server#869 |
wopian
added
javascript
There was a problem hiding this comment.
Do we want to set up the "remote Login URL" thing? https://nolt.io/help/single-sign-on
| <li class="nav-item dropdown"> | ||
| <a class="nav-link dropdown-toggle {{if isFeedbackRoute "active"}}" href="#" data-toggle="dropdown" data-href-to-ignore=true> | ||
| <li class="nav-item nolt-button"> | ||
| <a class="nav-link" href="#" data-href-to-ignore=true> |
There was a problem hiding this comment.
We should probably link this to https://feedback.kitsu.io/ to still function in case the Nolt widget breaks or gets blocked
| <div class="dropdown-menu"> | ||
| <a class="dropdown-item" href={{href-to "feedback.bugs"}}>{{t "feedback.bugs"}}</a> | ||
| <a class="dropdown-item" href={{href-to "feedback.feature-requests"}}>{{t "feedback.features"}}</a> | ||
| <a class="dropdown-item" href="https://kitsu-stuff.com" target="_blank" rel="noopener">{{t "feedback.database"}}</a> |
There was a problem hiding this comment.
I'm shocked I didn't notice this
| @@ -137,5 +139,8 @@ | |||
| }, | |||
| "resolutions": { | |||
| "ember-power-select/ember-concurrency": "0.8.27" | |||
| }, | |||
| "dependencies": { | |||
| "@apollo/client": "^3.1.1" | |||
There was a problem hiding this comment.
Is this supposed to be a devDependency like the others? Ember is weird
| this._super(...arguments); | ||
|
|
||
| nolt('init', { | ||
| selector: '.nolt-button', |
There was a problem hiding this comment.
Hmmm. Would it be better to create a component that detects its own id and uses that to build a selector?
We probably want to do this. The canny integration has started getting spammed by non-Kitsu accounts over the past year which I've had to delete. |
👢 🗑️
I've observed an issue here where moment timezone doesn't seem to get imported properly and it breaks the
_getCurrentUsermethod in theapplicationroute. Not sure if it's something weird on my end so would appreciate if whoever reviews this could check if that works for them. Dunno if the discussion here is related: #775