2.x.x mongokitten tutorial #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Joannis
commented
Jan 18, 2024
Joannis
commented
- Needs to use swift-server/hummingbird-openapi once merged
- Needs to use the alpha once tagged
9 tasks
adam-fowler
requested changes
Jan 18, 2024
There was a problem hiding this comment.
This looks really good. Nice alternative to the other todo samples, as you have used openapi.
- As an example it needs more comments.
- There needs to be README.md explaining what the sample is and how to run it. I guess you need a locally running mongodb instance. Does it need some setup?
- Also the README in the root needs updated, to include a link
todos-mongokitten-openapi/Sources/todos-mongokitten-openapi/API.swift
Outdated
Show resolved
Hide resolved
Joannis
force-pushed
the
2.x.x-mongokitten-tutorial
branch
from
aaa0176 to
639cbdc
Compare
adam-fowler
requested changes
Jan 22, 2024
Co-authored-by: Adam Fowler <[email protected]>
adam-fowler
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.