Use BasicAuthenticator from hummingbird-auth #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
commented
Aug 11, 2024
auth-jwt/Package.swift
Outdated
| @@ -11,7 +11,7 @@ let package = Package( | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/hummingbird-project/hummingbird.git", from: "2.0.0-rc.1"), | |||
| .package(url: "https://github.com/hummingbird-project/hummingbird-auth.git", from: "2.0.0-beta.4"), | |||
| .package(url: "https://github.com/hummingbird-project/hummingbird-auth.git", branch: "basic-auth"), | |||
There was a problem hiding this comment.
Remember to revert before merging
Joannis
reviewed
Aug 14, 2024
sessions/Package.swift
Outdated
| @@ -11,7 +11,7 @@ let package = Package( | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/hummingbird-project/hummingbird.git", from: "2.0.0-rc.1"), | |||
| .package(url: "https://github.com/hummingbird-project/hummingbird-auth.git", from: "2.0.0-beta.4"), | |||
| .package(url: "https://github.com/hummingbird-project/hummingbird-auth.git", branch: "main"), | |||
There was a problem hiding this comment.
All of these need updating of course
Joannis
reviewed
Aug 14, 2024
| @@ -4,7 +4,7 @@ import HummingbirdAuth | |||
| import HummingbirdFluent | |||
| import WebAuthn | |||
|
|
|||
| final class WebAuthnCredential: Model { | |||
| final class WebAuthnCredential: Model, @unchecked Sendable { | |||
Joannis
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit examples to use both BasicAuthenticator and SessionAuthenticator